Rename DRA feature gates to avoid conflict with upstream Kubernetes gates#11255
Merged
k8s-ci-robot merged 1 commit intoMay 18, 2026
Merged
Conversation
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
There was a problem hiding this comment.
Pull request overview
Renames Kueue's DRA-related feature gates (DynamicResourceAllocation → KueueDRAIntegration, DRAExtendedResources → KueueDRAIntegrationExtendedResource) to avoid name collisions with upstream Kubernetes feature gates. The old names are kept as Deprecated aliases for one release with an automatic migration step on startup.
Changes:
- Added new canonical feature gate names and marked the old ones
Deprecated(to be removed in 0.19), with aMigrateDeprecatedDRAFeatureGateshelper invoked fromcmd/kueue/main.gobefore config validation. - Updated all internal call sites (controllers, cache, dra, workload, validation), tests, KEP, site docs, and versioned feature list to use the new names.
- Extended
Validateto requireKueueDRAIntegrationwheneverKueueDRAIntegrationExtendedResourceis enabled, and updated the legacyDRAExtendedResourcescheck to accept either gate.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/features/kube_features.go | Adds new gate names, marks old ones Deprecated, and adds migration helper. |
| cmd/kueue/main.go | Calls migration before validation; uses new gate name for DRA mapper init. |
| pkg/config/validation.go | New validateDRAFeatureGateDependencies checking both new and legacy gate combinations. |
| pkg/config/validation_test.go | Replaces legacy dependency test with one for the new gate names. |
| pkg/controller/core/{core,workload_controller,indexer/indexer}.go | Switches gate references to new names; updates user-visible inadmissibility message. |
| pkg/controller/core/workload_controller_test.go | Updates fixtures to new gate names and expected message. |
| pkg/cache/queue/cluster_queue.go, pkg/dra/extended_resources.go, pkg/workload/workload*.go | Switches gate references to new names. |
| test/integration/.../dra/{suite_test,dra_test}.go, fairsharing/suite_test.go, multikueue/dra_test.go | Updates feature-gate names in integration tests. |
| keps/2941-DRA/kep.yaml | Replaces gate names in KEP metadata. |
| site/content/en/docs/{concepts/dynamic_resource_allocation,tasks/manage/setup_dra,tasks/run/dra}.md | Documents the rename and updates examples/text. |
| site/data/featuregates/versioned_feature_list.yaml, test/compatibility_lifecycle/reference/versioned_feature_list.yaml | Adds 0.18 Deprecated entries for old gates and Alpha entries for new ones. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sohankunkerkar
force-pushed
the
rename-dra-feature-gates
branch
3 times, most recently
from
5fb1c87 to
e277533
Compare
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-rebase
mimowo
reviewed
May 18, 2026
sohankunkerkar
force-pushed
the
rename-dra-feature-gates
branch
from
e277533 to
1eedbcc
Compare
k8s-ci-robot
removed
the
needs-rebase
mimowo
reviewed
May 18, 2026
Contributor
mimowo
left a comment
mimowo
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thank you 👍
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: c82e444dda2c0cfde338461090afe0555b83a38c |
k8s-ci-robot
added
the
approved
Member
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
tenzen-y
reviewed
May 18, 2026
Member
tenzen-y
left a comment
tenzen-y
left a comment
There was a problem hiding this comment.
Can you lock deprecated FG and add a comment for the removal version?
sohankunkerkar
force-pushed
the
rename-dra-feature-gates
branch
from
1eedbcc to
bd71911
Compare
k8s-ci-robot
removed
the
lgtm
tenzen-y
reviewed
May 18, 2026
Member
tenzen-y
left a comment
tenzen-y
left a comment
There was a problem hiding this comment.
Thank you!
/lgtm
/approve
/hold cancel
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: d5fbbda2573cbc628b87c2e911c9b679aa877ca9 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, sohankunkerkar, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sohankunkerkar
force-pushed
the
rename-dra-feature-gates
branch
from
bd71911 to
0b042f0
Compare
k8s-ci-robot
removed
the
lgtm
Member
|
I confirmed that the new commit has only formatting fix. |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 71658c32b6657f5103933a43723b886c0902c0b5 |
sohankunkerkar
force-pushed
the
rename-dra-feature-gates
branch
from
0b042f0 to
9f69f09
Compare
k8s-ci-robot
removed
the
lgtm
…ates Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
sohankunkerkar
force-pushed
the
rename-dra-feature-gates
branch
from
9f69f09 to
bc004fe
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8dc73dc0e4985fd5a508a6f808fa39ebf4da9af3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Renames DRA feature gates to avoid name collisions with upstream Kubernetes feature gates
(see #8871 for the scheduler-library integration where this became problematic):
DynamicResourceAllocationKueueDRAIntegrationDRAExtendedResourcesKueueDRAIntegrationExtendedResourceUpgrade scenarios
DynamicResourceAllocation: trueKueueDRAIntegration=true. DRA works.DynamicResourceAllocation: true, DRAExtendedResources: trueKueueDRAIntegration: true, KueueDRAIntegrationExtendedResource: trueKueueDRAIntegration: trueDynamicResourceAllocation: true, KueueDRAIntegration: false(explicit)ExplicitlySetcheck). DRA disabled per user intent.KueueDRAIntegrationExtendedResource: true(no base gate)Validate()rejects: "requires KueueDRAIntegration to be enabled". Startup fails.Which issue(s) this PR fixes:
Fixes #11248
Special notes for your reviewer:
The e2e DRA config (
test/e2e/config/dra/controller_manager_config.yaml) intentionallykeeps old gate names to exercise the migration path. The DRA e2e tests pass with this config.
Does this PR introduce a user-facing change?